Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add generateName to devfile metadata with persistance #14158

Closed
wants to merge 6 commits into from
Closed

add generateName to devfile metadata with persistance #14158

wants to merge 6 commits into from

Conversation

sparkoo
Copy link
Member

@sparkoo sparkoo commented Aug 8, 2019

What does this PR do?

Work In Progress PR!
Adds generateName field to devfile metadata with persistance. This updates workspace/devfile relation as workspace.name is here source of truth instead of just getting the name from devfile or config. This introduces several issues like what should happen when editing devfile on dashboard if I change generateName field?

What issues does this PR fix or reference?

#13794 (see comment #13794 (comment)) and also see PR that solves the issue without introducing new field into the database #14157 and is sufficient for fixing the issue

Release Notes

Docs PR

Signed-off-by: Michal Vala <mvala@redhat.com>
Signed-off-by: Michal Vala <mvala@redhat.com>
…/config name

Signed-off-by: Michal Vala <mvala@redhat.com>
Signed-off-by: Michal Vala <mvala@redhat.com>
Signed-off-by: Michal Vala <mvala@redhat.com>
…set there

Signed-off-by: Michal Vala <mvala@redhat.com>
@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/bug Outline of a bug - must adhere to the bug report template. labels Aug 8, 2019
@che-bot
Copy link
Contributor

che-bot commented Aug 8, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14158

@sleshchenko
Copy link
Member

Does it need a review or it can be closed in favor of #14157

@sparkoo
Copy link
Member Author

sparkoo commented Aug 9, 2019

@sleshchenko I guess we can close it. I've just wanted to share the idea of decoupling name of devfile from name of workspace instance

@sparkoo sparkoo closed this Aug 9, 2019
@sparkoo sparkoo deleted the generateName branch August 22, 2019 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants