-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add generateName
to devfile metadata with persistance
#14158
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michal Vala <mvala@redhat.com>
Signed-off-by: Michal Vala <mvala@redhat.com>
…/config name Signed-off-by: Michal Vala <mvala@redhat.com>
Signed-off-by: Michal Vala <mvala@redhat.com>
Signed-off-by: Michal Vala <mvala@redhat.com>
…set there Signed-off-by: Michal Vala <mvala@redhat.com>
che-bot
added
status/code-review
This issue has a pull request posted for it and is awaiting code review completion by the community.
kind/bug
Outline of a bug - must adhere to the bug report template.
labels
Aug 8, 2019
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:
|
Does it need a review or it can be closed in favor of #14157 |
@sleshchenko I guess we can close it. I've just wanted to share the idea of decoupling name of devfile from name of workspace instance |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
kind/bug
Outline of a bug - must adhere to the bug report template.
status/code-review
This issue has a pull request posted for it and is awaiting code review completion by the community.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Work In Progress PR!
Adds
generateName
field to devfile metadata with persistance. This updates workspace/devfile relation asworkspace.name
is here source of truth instead of just getting the name fromdevfile
orconfig
. This introduces several issues like what should happen when editing devfile on dashboard if I changegenerateName
field?What issues does this PR fix or reference?
#13794 (see comment #13794 (comment)) and also see PR that solves the issue without introducing new field into the database #14157 and is sufficient for fixing the issue
Release Notes
Docs PR